Discrete control with discrete callback #1393
Merged
+127
−319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…set_point_with_minmax model and associated tests
…h_discrete_callback
18 tasks
evetion
requested changes
Apr 17, 2024
evetion
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #455, fixes #495. The latter is made redundant by this PR since U/D truth values are removed.
Upgrade instructions
This changes DiscreteControl, to only check the conditions on each timestep. Before it used root finding to determine the exact moment a threshold is crossed. This method is simpler and will likely scale better. If it is important that threshold crossings are recognized without too much delay, it is important to set the
dtmaxordtappropriately. With this change the U and D conditions for upcrossing and downcrossing are no longer supported.